Move torchvision dependency to optional dev-test group #325
Conversation
Signed-off-by: Keval Morabia <[email protected]>
WalkthroughMoved torchvision from install-time required dependencies to an optional extra under dev-test in setup.py. No changes to exported/public entity signatures. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
setup.py (1)
104-109: Avoid duplicated extras in the 'dev' aggregator.
Including the newly added "all" list inside "dev" duplicates entries. Not harmful, but noisy and nondeterministic across changes. Simple tidy-up:-optional_deps["dev"] = [deps for k in optional_deps for deps in optional_deps[k]] +# Exclude the aggregated "all" key to avoid duplication; order remains stable +optional_deps["dev"] = [dep for k, deps in optional_deps.items() if k != "all" for dep in deps]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
setup.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: linux
- GitHub Check: wait-checks / wait
- GitHub Check: code-quality
- GitHub Check: build-docs
🔇 Additional comments (2)
setup.py (2)
75-84: Pin torchvision to a torch-compatible range or add CI constraintsUnpinned "torchvision" in setup.py dev-test extras (setup.py, lines 75–84) can resolve to a torchvision incompatible with the installed torch and cause operator/ABI/runtime errors. Either:
- Pin torchvision to match your torch (examples: torch 2.6 → torchvision 0.21., torch 2.7 → torchvision 0.22., torch 2.8 → torchvision 0.23.*).
- Or keep it unpinned here but add a constraints file used by tox/CI that pins a known-good torch/torchvision pair.
75-84: Move torchvision to dev-test extra — LGTM; tox/CI already wired, but verify no runtime imports.
- Evidence: setup.py contains the dev-test extra (~line 75); tox.ini installs -e .[all,dev-test] in unit/GPU envs and references dev-test in partial-unit envs; docker/Dockerfile references [all,dev-test].
- Action required: confirm there are no runtime imports of torchvision in non-test code (search for "import torchvision" and dynamic imports). Tests that require torchvision should use pytest.importorskip('torchvision') or run under CI/tox that installs the dev-test extra.
What does this PR do?
torchvisionis only used in tests so we should not make it default dependencySummary by CodeRabbit